Skip to content

MQE-782: Fatal error is thrown when a group name conflicts with an existing suite name #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

magterskine
Copy link
Contributor

Description

During generation, for the specified test set, if there is a conflict between a suite name and a group name, generation fails. An error is printed with the suite and test details of the conflict

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Apr 5, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 51.273% when pulling 6bdde68 on MQE-782 into fc58bae on develop.

@coveralls
Copy link

coveralls commented Apr 5, 2018

Coverage Status

Coverage decreased (-0.004%) to 51.339% when pulling 3550ecd on MQE-782 into 2e466f2 on develop.

…isting suite name

- Added getter for $filename to TestObject
- Added check for matching suite and groups names to SuiteObjectExtractor

MQE-782: Fatal error is thrown when a group name conflicts with an existing suite name

- Fixed static check failures on line length

MQE-782: Fatal error is thrown when a group name conflicts with an existing suite name

- Modified exception message formatting for more readable output

MQE-782: Fatal error is thrown when a group name conflicts with an existing suite name

- Suppress Warnings for Cyclomatic and NPath SuiteObjectExtractor::parseSuiteDataIntoObjects
@magterskine magterskine merged commit 3ae57a6 into develop Apr 5, 2018
@magterskine magterskine deleted the MQE-782 branch April 9, 2018 15:50
magento-devops-reposync-svc pushed a commit that referenced this pull request Jul 28, 2021
…2-functional-testing-framework-866

[Imported] Add access/secret key config parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants